Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Build and deploy testnet #129

Merged
merged 5 commits into from
May 31, 2024
Merged

build: Build and deploy testnet #129

merged 5 commits into from
May 31, 2024

Conversation

bgins
Copy link
Contributor

@bgins bgins commented May 29, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

This pull request implements the following changes:

  • Remove Cloudflare token and Doppler environment from solver and job creator Dockerfiles
  • Add testnet_deploy_contracts action
  • Add testnet_deploy_services action to build and deploy solver and job-creator to Testnet
  • Add testnet_restart_solver and testnet_restart_job_creator actions to restarts services individually
  • Update Devnet documentation to use Ubuntu instead of Amazon Linux

All GitHub actions are run on-demand for the moment.

Note that testnet_deploy_contracts depends on the #122 where the arbitrumSepolia network is defined. We could wait on this one if we prefer to hold off until the other PR is merged.

Task/Issue reference

Implements #124

Details

How to test this code?

Local builds for the Docker images should succeed and work with the local stack.

The GH actions can only be run on-demand once this PR reaches main, but here are the last runs while working on them:

testnet_deploy_contracts has not been tested, but is quite similar to the Devnet contract deploy action:

contracts:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
context: app
- name: Install Doppler CLI
uses: dopplerhq/cli-action@v1
# TODO Avoid re-deploying contracts that are already on chain
- name: Deploy contracts
id: deploy-contracts
env:
DOPPLER_TOKEN: ${{ secrets.DOPPLER_TOKEN_CONTRACTS_DEPLOY_DEVNET }}
run: |
cd hardhat
npm ci
doppler run -- npx hardhat deploy --network geth

@bgins bgins force-pushed the bgins/build-deploy-testnet branch 25 times, most recently from 7de229d to 073c40d Compare May 31, 2024 02:50
@bgins bgins marked this pull request as ready for review May 31, 2024 03:00
@bgins bgins requested a review from AquiGorka May 31, 2024 03:01
run: |
cd hardhat
npm ci
doppler run -- npx hardhat deploy --network arbitrumSepolia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to validate this works locally, to confirm we get the same contract addresses every time.

@@ -0,0 +1,17 @@
name: Restart Testnet job creator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 🕺 🎉 thank you @bgins !

@bgins bgins force-pushed the bgins/build-deploy-testnet branch from 073c40d to abc2bbd Compare May 31, 2024 18:37
@bgins bgins force-pushed the bgins/build-deploy-testnet branch 2 times, most recently from f8c77b0 to 42504b4 Compare May 31, 2024 18:54
@bgins bgins merged commit d63d8b5 into main May 31, 2024
1 check passed
@bgins bgins deleted the bgins/build-deploy-testnet branch May 31, 2024 18:57
arsen3d pushed a commit that referenced this pull request Jun 11, 2024
* docs: Update VM instructions to use Ubuntu

* build: Add testnet contracts deploy action

* build: Remove Cloudflare token and Doppler config

* build: Add testnet solver and job-creator build and deploy

* build: Add restart Testnet solver and job creator actions
@bgins bgins self-assigned this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants